Code-Review on Brian Faust

A Code Review Should Test the Decision, Not the Author

Thu, 01 Aug 2019 00:00:00 +0000

One booking flow could trigger the same automatic wallet refill twice. The first refill happened while booking. A later debit event ran the ordinary refill check again.

The retained correction wrote a short-lived marker per account containing the pending amount. When a matching shipment debit arrived, it consumed the marker and skipped one refill. Focused tests covered the expected sequence.

That is enough to begin a review, not finish one. The decision is not “is this cache helper elegant?” It is:

A Small Change Limits the States a Reviewer Must Hold

Mon, 01 Jul 2019 00:00:00 +0000

A table needed four columns, a self-referencing constraint, and an index. The first migration added everything in one schema callback. That was concise, but production could already contain any subset of those objects.

The repair was longer. Each column, constraint, and index became a separate guarded migration. The constraint waited for its column. The index waited for both of its columns. Rollback deliberately removed nothing because some schema objects might predate the repair.